Skip to content

Commit b781fa7

Browse files
danbevjasnell
authored andcommitted
test: add override to ServerDone function
Currently the following compiler warning is displayed when building: ../test/cctest/test_inspector_socket_server.cc:142:8: warning: 'ServerDone' overrides a member function but is not marked 'override' [-Winconsistent-missing-override] void ServerDone() { ^ ../src/inspector_socket_server.h:30:16: note: overridden virtual function is here virtual void ServerDone() = 0; ^ This commit marks ServerDone with override to get rid of the warning. PR-URL: #13166 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Refael Ackermann <[email protected]>
1 parent c15fe8b commit b781fa7

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/cctest/test_inspector_socket_server.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate {
139139
server_->Send(session_id_, message);
140140
}
141141

142-
void ServerDone() {
142+
void ServerDone() override {
143143
done = true;
144144
}
145145

0 commit comments

Comments
 (0)