Skip to content

Commit b82fc40

Browse files
guybedfordMylesBorins
authored andcommitted
module: [email protected] big endian fix
PR-URL: #35634 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]>
1 parent 775af7a commit b82fc40

File tree

5 files changed

+9
-15
lines changed

5 files changed

+9
-15
lines changed

deps/cjs-module-lexer/dist/lexer.js

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

deps/cjs-module-lexer/dist/lexer.mjs

+2-2
Large diffs are not rendered by default.

deps/cjs-module-lexer/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "cjs-module-lexer",
3-
"version": "0.4.0",
3+
"version": "0.4.2",
44
"description": "Lexes CommonJS modules, returning their named exports metadata",
55
"main": "lexer.js",
66
"exports": {

doc/api/esm.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1282,7 +1282,7 @@ success!
12821282
[`transformSource` hook]: #esm_transformsource_source_context_defaulttransformsource
12831283
[`string`]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String
12841284
[`util.TextDecoder`]: util.md#util_class_util_textdecoder
1285-
[cjs-module-lexer]: https://github.com/guybedford/cjs-module-lexer/tree/0.4.0
1285+
[cjs-module-lexer]: https://github.com/guybedford/cjs-module-lexer/tree/0.4.2
12861286
[special scheme]: https://url.spec.whatwg.org/#special-scheme
12871287
[the official standard format]: https://tc39.github.io/ecma262/#sec-modules
12881288
[transpiler loader example]: #esm_transpiler_loader

lib/internal/modules/esm/translators.js

+4-10
Original file line numberDiff line numberDiff line change
@@ -60,20 +60,14 @@ const { emitWarningSync } = require('internal/process/warning');
6060

6161
let cjsParse;
6262
async function initCJSParse() {
63-
if (typeof WebAssembly !== 'undefined') {
63+
if (typeof WebAssembly === 'undefined') {
64+
cjsParse = require('internal/deps/cjs-module-lexer/lexer');
65+
} else {
6466
const { parse, init } =
6567
require('internal/deps/cjs-module-lexer/dist/lexer');
6668
await init();
67-
let exports;
68-
try {
69-
({ exports } = parse('exports.a=1'));
70-
if (exports.length === 1) {
71-
cjsParse = parse;
72-
return;
73-
}
74-
} catch {}
69+
cjsParse = parse;
7570
}
76-
cjsParse = require('internal/deps/cjs-module-lexer/lexer');
7771
}
7872

7973
const translators = new SafeMap();

0 commit comments

Comments
 (0)