Skip to content

Commit b9e9797

Browse files
authored
doc: document breaking change in http.IncomingMessage 'close' event
PR-URL: #42521 Fixes: #38924 Refs: #33035 Reviewed-By: Robert Nagy <[email protected]> Reviewed-By: Beth Griggs <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
1 parent fd18b0e commit b9e9797

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

doc/api/http.md

+6-1
Original file line numberDiff line numberDiff line change
@@ -2112,9 +2112,14 @@ Emitted when the request has been aborted.
21122112

21132113
<!-- YAML
21142114
added: v0.4.2
2115+
changes:
2116+
- version: v16.0.0
2117+
pr-url: https://github.com/nodejs/node/pull/33035
2118+
description: The close event is now emitted when the request has been completed and not when the
2119+
underlying socket is closed.
21152120
-->
21162121

2117-
Indicates that the underlying connection was closed.
2122+
Emitted when the request has been completed.
21182123

21192124
### `message.aborted`
21202125

doc/changelogs/CHANGELOG_V16.md

+1
Original file line numberDiff line numberDiff line change
@@ -2447,6 +2447,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
24472447
* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
24482448
* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
24492449
* **(SEMVER-MINOR)** **http**: add http.ClientRequest.getRawHeaderNames() (simov) [#37660](https://github.com/nodejs/node/pull/37660)
2450+
* **(SEMVER-MAJOR)** **http**: use `autoDestroy: true` in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
24502451
* **(SEMVER-MAJOR)** **lib,src**: update cluster to use Parent (Michael Dawson) [#36478](https://github.com/nodejs/node/pull/36478)
24512452
* **(SEMVER-MINOR)** **module**: add support for `node:`‑prefixed `require(…)` calls (ExE Boss) [#37246](https://github.com/nodejs/node/pull/37246)
24522453
* **(SEMVER-MINOR)** **perf\_hooks**: add histogram option to timerify (James M Snell) [#37475](https://github.com/nodejs/node/pull/37475)

0 commit comments

Comments
 (0)