Skip to content

Commit bb2fdf5

Browse files
stefanmbMyles Borins
authored and
Myles Borins
committed
build: cherry pick V8 change for windows DLL support
Ref: #9385 PR-URL: #8084 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 527db40 commit bb2fdf5

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

deps/v8/build/toolchain.gypi

+4-3
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@
3939
'ubsan_vptr%': 0,
4040
'v8_target_arch%': '<(target_arch)',
4141
'v8_host_byteorder%': '<!(python -c "import sys; print sys.byteorder")',
42+
'force_dynamic_crt%': 0,
4243
# Native Client builds currently use the V8 ARM JIT and
4344
# arm/simulator-arm.cc to defer the significant effort required
4445
# for NaCl JIT support. The nacl_target_arch variable provides
@@ -995,7 +996,7 @@
995996
'VCCLCompilerTool': {
996997
'Optimization': '0',
997998
'conditions': [
998-
['component=="shared_library"', {
999+
['component=="shared_library" or force_dynamic_crt==1', {
9991000
'RuntimeLibrary': '3', # /MDd
10001001
}, {
10011002
'RuntimeLibrary': '1', # /MTd
@@ -1047,7 +1048,7 @@
10471048
'StringPooling': 'true',
10481049
'BasicRuntimeChecks': '0',
10491050
'conditions': [
1050-
['component=="shared_library"', {
1051+
['component=="shared_library" or force_dynamic_crt==1', {
10511052
'RuntimeLibrary': '3', #/MDd
10521053
}, {
10531054
'RuntimeLibrary': '1', #/MTd
@@ -1235,7 +1236,7 @@
12351236
'FavorSizeOrSpeed': '0',
12361237
'StringPooling': 'true',
12371238
'conditions': [
1238-
['component=="shared_library"', {
1239+
['component=="shared_library" or force_dynamic_crt==1', {
12391240
'RuntimeLibrary': '2', #/MD
12401241
}, {
12411242
'RuntimeLibrary': '0', #/MT

deps/v8/include/v8-version.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
#define V8_MAJOR_VERSION 4
1212
#define V8_MINOR_VERSION 5
1313
#define V8_BUILD_NUMBER 103
14-
#define V8_PATCH_LEVEL 42
14+
#define V8_PATCH_LEVEL 43
1515

1616
// Use 1 for candidates and 0 otherwise.
1717
// (Boolean macro values are not supported by all preprocessors.)

0 commit comments

Comments
 (0)