Skip to content

Commit bb77cce

Browse files
Eugene Ostroukhovjasnell
Eugene Ostroukhov
authored andcommitted
inspector: add missing virtual destructor
This fixes a resource leak detected by a Coverity scan. PR-URL: #13198 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Aleksei Koziatinskii <[email protected]>
1 parent 145ab05 commit bb77cce

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

src/inspector_agent.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ class JsBindingsSessionDelegate : public InspectorSessionDelegate {
195195
v8::WeakCallbackType::kParameter);
196196
}
197197

198-
virtual ~JsBindingsSessionDelegate() {
198+
~JsBindingsSessionDelegate() override {
199199
session_.Reset();
200200
receiver_.Reset();
201201
callback_.Reset();

src/inspector_agent.h

+1
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@ namespace inspector {
3737

3838
class InspectorSessionDelegate {
3939
public:
40+
virtual ~InspectorSessionDelegate() = default;
4041
virtual bool WaitForFrontendMessage() = 0;
4142
virtual void OnMessage(const v8_inspector::StringView& message) = 0;
4243
};

0 commit comments

Comments
 (0)