Skip to content

Commit bbc3f46

Browse files
joaocgreistargos
authored andcommitted
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h and therefore prevents compilation of addons. Refs: https://stackoverflow.com/q/38378693 PR-URL: #32116 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 0c98864 commit bbc3f46

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

Diff for: common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.4',
39+
'v8_embedder_string': '-node.5',
4040

4141
##### V8 defaults for Node.js #####
4242

Diff for: deps/v8/include/v8.h

+2
Original file line numberDiff line numberDiff line change
@@ -1834,9 +1834,11 @@ class V8_EXPORT ScriptCompiler {
18341834
public:
18351835
enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 };
18361836

1837+
#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */
18371838
V8_DEPRECATE_SOON(
18381839
"This class takes ownership of source_stream, so use the constructor "
18391840
"taking a unique_ptr to make these semantics clearer")
1841+
#endif
18401842
StreamedSource(ExternalSourceStream* source_stream, Encoding encoding);
18411843
StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream,
18421844
Encoding encoding);

0 commit comments

Comments
 (0)