Skip to content

Commit bbfb014

Browse files
committed
test: split test-crypto-dh-hash
test-crypto-dh-hash times out on some platforms. A single test case is responsible for around 50% of the time to run, so split that test case into its own file. PR-URL: #34631 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 49a1f7f commit bbfb014

File tree

2 files changed

+42
-1
lines changed

2 files changed

+42
-1
lines changed
+42
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
// Copyright Joyent, Inc. and other Node contributors.
2+
//
3+
// Permission is hereby granted, free of charge, to any person obtaining a
4+
// copy of this software and associated documentation files (the
5+
// "Software"), to deal in the Software without restriction, including
6+
// without limitation the rights to use, copy, modify, merge, publish,
7+
// distribute, sublicense, and/or sell copies of the Software, and to permit
8+
// persons to whom the Software is furnished to do so, subject to the
9+
// following conditions:
10+
//
11+
// The above copyright notice and this permission notice shall be included
12+
// in all copies or substantial portions of the Software.
13+
//
14+
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS
15+
// OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
16+
// MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN
17+
// NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM,
18+
// DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR
19+
// OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE
20+
// USE OR OTHER DEALINGS IN THE SOFTWARE.
21+
22+
'use strict';
23+
const common = require('../common');
24+
if (!common.hasCrypto)
25+
common.skip('node compiled without OpenSSL.');
26+
27+
const assert = require('assert');
28+
const crypto = require('crypto');
29+
30+
const hashes = {
31+
modp18: 'a870b491bbbec9b131ae9878d07449d32e54f160'
32+
};
33+
34+
for (const name in hashes) {
35+
const group = crypto.getDiffieHellman(name);
36+
const private_key = group.getPrime('hex');
37+
const hash1 = hashes[name];
38+
const hash2 = crypto.createHash('sha1')
39+
.update(private_key.toUpperCase()).digest('hex');
40+
assert.strictEqual(hash1, hash2);
41+
assert.strictEqual(group.getGenerator('hex'), '02');
42+
}

test/pummel/test-crypto-dh-hash.js

-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ const hashes = {
3535
modp15: '7bdd39e5cdbb9748113933e5c2623b559c534e74',
3636
modp16: 'daea5277a7ad0116e734a8e0d2f297ef759d1161',
3737
modp17: '3b62aaf0142c2720f0bf26a9589b0432c00eadc1',
38-
modp18: 'a870b491bbbec9b131ae9878d07449d32e54f160'
3938
};
4039

4140
for (const name in hashes) {

0 commit comments

Comments
 (0)