Skip to content

Commit bc99efc

Browse files
vsemozhetbytFishrock123
authored andcommittedJul 19, 2017
test: simplify test skipping
* Make common.skip() exit. Also add common.printSkipMessage() for partial skips. * Don't make needless things before skip PR-URL: #14021 Fixes: #14016 Reviewed-By: Refael Ackermann <[email protected]>
1 parent 898fe61 commit bc99efc

File tree

333 files changed

+896
-1633
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

333 files changed

+896
-1633
lines changed
 

‎test/abort/test-abort-backtrace.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
'use strict';
22
const common = require('../common');
3+
if (common.isWindows)
4+
common.skip('Backtraces unimplemented on Windows.');
5+
36
const assert = require('assert');
47
const cp = require('child_process');
58

6-
if (common.isWindows) {
7-
common.skip('Backtraces unimplemented on Windows.');
8-
return;
9-
}
10-
119
if (process.argv[2] === 'child') {
1210
process.abort();
1311
} else {

‎test/addons/load-long-path/test.js

+3-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
11
'use strict';
22
const common = require('../../common');
3+
if (common.isWOW64)
4+
common.skip('doesn\'t work on WOW64');
5+
36
const fs = require('fs');
47
const path = require('path');
58
const assert = require('assert');
69

7-
if (common.isWOW64) {
8-
common.skip('doesn\'t work on WOW64');
9-
return;
10-
}
11-
1210
common.refreshTmpDir();
1311

1412
// make a path that is more than 260 chars long.

0 commit comments

Comments
 (0)
Please sign in to comment.