Skip to content

Commit bd9109c

Browse files
committed
lib: move DEP0021 to end of life
Server.listenFD() has been runtime deprecated since Node 0.7.12. This commit moves the deprecation to end-of-life. PR-URL: #27127 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Joyee Cheung <[email protected]>
1 parent 41d5666 commit bd9109c

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

doc/api/deprecations.md

+5-2
Original file line numberDiff line numberDiff line change
@@ -483,6 +483,9 @@ The [`Server.connections`][] property is deprecated. Please use the
483483
### DEP0021: Server.listenFD
484484
<!-- YAML
485485
changes:
486+
- version: REPLACEME
487+
pr-url: https://github.com/nodejs/node/pull/27127
488+
description: End-of-Life.
486489
- version:
487490
- v4.8.6
488491
- v6.12.0
@@ -493,9 +496,9 @@ changes:
493496
description: Runtime deprecation.
494497
-->
495498

496-
Type: Runtime
499+
Type: End-of-Life
497500

498-
The `Server.listenFD()` method is deprecated. Please use
501+
The `Server.listenFD()` method was deprecated and removed. Please use
499502
[`Server.listen({fd: <number>})`][] instead.
500503

501504
<a id="DEP0022"></a>

lib/net.js

-6
Original file line numberDiff line numberDiff line change
@@ -1590,12 +1590,6 @@ Object.defineProperty(Socket.prototype, '_handle', {
15901590
set(v) { return this[kHandle] = v; }
15911591
});
15921592

1593-
1594-
Server.prototype.listenFD = deprecate(function(fd, type) {
1595-
return this.listen({ fd: fd });
1596-
}, 'Server.listenFD is deprecated. Use Server.listen({fd: <number>}) instead.',
1597-
'DEP0021');
1598-
15991593
Server.prototype._setupWorker = function(socketList) {
16001594
this._usingWorkers = true;
16011595
this._workers.push(socketList);

0 commit comments

Comments
 (0)