Skip to content

Commit bedc6e2

Browse files
BridgeARtargos
authored andcommitted
tools: allow the travis commit message job to fail
Travis often fails due to a commit message that does not adhere to the commit guidelines. We are able to fix the commit message while landing and it often confuses new contributors that travis fails. Keeping the check in place but allowing a test failure to report success should be a good middle ground. PR-URL: #31116 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
1 parent 48e1dfe commit bedc6e2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

.travis.yml

+1
Original file line numberDiff line numberDiff line change
@@ -88,3 +88,4 @@ jobs:
8888
- flake8 . --count --select=E9,F63,F7,F82 --show-source --statistics
8989
allow_failures: # TODO (cclauss): remove this when dependencies are clean
9090
- name: "Find syntax errors in our Python dependencies"
91+
- name: "First commit message adheres to guidelines at <a href=\"https://goo.gl/p2fr5Q\">https://goo.gl/p2fr5Q</a>"

0 commit comments

Comments
 (0)