Skip to content

Commit bf5c309

Browse files
committed
build: fix V8 build on FreeBSD
Use the -D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1 flag because on FreeBSD std::pairs copy constructor is non-trivial. Refs: https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html Refs: https://github.com/gliaskos/freebsd-chromium/blob/master/www/chromium/Makefile#L202-L205 PR-URL: #12784 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 5b63fab commit bf5c309

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

common.gypi

+3
Original file line numberDiff line numberDiff line change
@@ -410,6 +410,9 @@
410410
'libraries': [ '-lelf' ],
411411
}],
412412
['OS=="freebsd"', {
413+
# Use this flag because on FreeBSD std::pairs copy constructor is non-trivial
414+
# https://lists.freebsd.org/pipermail/freebsd-toolchain/2016-March/002094.html
415+
'cflags': [ '-D_LIBCPP_TRIVIAL_PAIR_COPY_CTOR=1' ],
413416
'ldflags': [
414417
'-Wl,--export-dynamic',
415418
],

0 commit comments

Comments
 (0)