Skip to content

Commit bf7a52b

Browse files
gengjiawenBridgeAR
authored andcommitted
http: improve for-loop readability in _http_outgoing.js
PR-URL: #26408 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent 5897bf4 commit bf7a52b

File tree

1 file changed

+15
-15
lines changed

1 file changed

+15
-15
lines changed

Diff for: lib/_http_outgoing.js

+15-15
Original file line numberDiff line numberDiff line change
@@ -295,21 +295,21 @@ function _storeHeader(firstLine, headers) {
295295
header: firstLine
296296
};
297297

298-
var key;
299-
if (headers === this[outHeadersKey]) {
300-
for (key in headers) {
301-
const entry = headers[key];
302-
processHeader(this, state, entry[0], entry[1], false);
303-
}
304-
} else if (Array.isArray(headers)) {
305-
for (var i = 0; i < headers.length; i++) {
306-
const entry = headers[i];
307-
processHeader(this, state, entry[0], entry[1], true);
308-
}
309-
} else if (headers) {
310-
for (key in headers) {
311-
if (hasOwnProperty(headers, key)) {
312-
processHeader(this, state, key, headers[key], true);
298+
if (headers) {
299+
if (headers === this[outHeadersKey]) {
300+
for (const key in headers) {
301+
const entry = headers[key];
302+
processHeader(this, state, entry[0], entry[1], false);
303+
}
304+
} else if (Array.isArray(headers)) {
305+
for (const entry of headers) {
306+
processHeader(this, state, entry[0], entry[1], true);
307+
}
308+
} else {
309+
for (const key in headers) {
310+
if (hasOwnProperty(headers, key)) {
311+
processHeader(this, state, key, headers[key], true);
312+
}
313313
}
314314
}
315315
}

0 commit comments

Comments
 (0)