Skip to content

Commit bfde244

Browse files
Shubhamurkadecodebytere
authored andcommitted
src: elevate repeated use of v8 namespaced type
PR-URL: #24427 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]>
1 parent d2d6287 commit bfde244

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/inspector_agent.cc

+7-6
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ using v8::Function;
3636
using v8::HandleScope;
3737
using v8::Isolate;
3838
using v8::Local;
39+
using v8::Message;
3940
using v8::Object;
4041
using v8::String;
4142
using v8::Value;
@@ -361,7 +362,7 @@ class SameThreadInspectorSession : public InspectorSession {
361362
};
362363

363364
void NotifyClusterWorkersDebugEnabled(Environment* env) {
364-
v8::Isolate* isolate = env->isolate();
365+
Isolate* isolate = env->isolate();
365366
HandleScope handle_scope(isolate);
366367
auto context = env->context();
367368

@@ -511,7 +512,7 @@ class NodeInspectorClient : public V8InspectorClient {
511512
}
512513
}
513514

514-
void FatalException(Local<Value> error, Local<v8::Message> message) {
515+
void FatalException(Local<Value> error, Local<Message> message) {
515516
Isolate* isolate = env_->isolate();
516517
Local<Context> context = env_->context();
517518

@@ -761,7 +762,7 @@ void Agent::WaitForDisconnect() {
761762
}
762763
}
763764

764-
void Agent::FatalException(Local<Value> error, Local<v8::Message> message) {
765+
void Agent::FatalException(Local<Value> error, Local<Message> message) {
765766
if (!IsListening())
766767
return;
767768
client_->FatalException(error, message);
@@ -773,8 +774,8 @@ void Agent::PauseOnNextJavascriptStatement(const std::string& reason) {
773774
}
774775

775776
void Agent::RegisterAsyncHook(Isolate* isolate,
776-
v8::Local<v8::Function> enable_function,
777-
v8::Local<v8::Function> disable_function) {
777+
Local<Function> enable_function,
778+
Local<Function> disable_function) {
778779
enable_async_hook_function_.Reset(isolate, enable_function);
779780
disable_async_hook_function_.Reset(isolate, disable_function);
780781
if (pending_enable_async_hook_) {
@@ -849,7 +850,7 @@ void Agent::RequestIoThreadStart() {
849850
// continuous JS code) and to wake up libuv thread (in case Node is waiting
850851
// for IO events)
851852
uv_async_send(&start_io_thread_async);
852-
v8::Isolate* isolate = parent_env_->isolate();
853+
Isolate* isolate = parent_env_->isolate();
853854
v8::Platform* platform = parent_env_->isolate_data()->platform();
854855
platform->CallOnForegroundThread(isolate, new StartIoTask(this));
855856
isolate->RequestInterrupt(StartIoInterrupt, this);

0 commit comments

Comments
 (0)