Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit c07c73c

Browse files
danbevaddaleax
authored andcommittedApr 23, 2018
src: rename return var in VerifySpkac functions
This commit renames the verification result variable, that is currently named i, to verify_result. PR-URL: #20218 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e3b0fb0 commit c07c73c

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed
 

‎src/node_crypto.cc

+7-7
Original file line numberDiff line numberDiff line change
@@ -5170,7 +5170,7 @@ void GetCurves(const FunctionCallbackInfo<Value>& args) {
51705170

51715171

51725172
bool VerifySpkac(const char* data, unsigned int len) {
5173-
bool i = false;
5173+
bool verify_result = false;
51745174
EVP_PKEY* pkey = nullptr;
51755175
NETSCAPE_SPKI* spki = nullptr;
51765176

@@ -5182,7 +5182,7 @@ bool VerifySpkac(const char* data, unsigned int len) {
51825182
if (pkey == nullptr)
51835183
goto exit;
51845184

5185-
i = NETSCAPE_SPKI_verify(spki, pkey) > 0;
5185+
verify_result = NETSCAPE_SPKI_verify(spki, pkey) > 0;
51865186

51875187
exit:
51885188
if (pkey != nullptr)
@@ -5191,23 +5191,23 @@ bool VerifySpkac(const char* data, unsigned int len) {
51915191
if (spki != nullptr)
51925192
NETSCAPE_SPKI_free(spki);
51935193

5194-
return i;
5194+
return verify_result;
51955195
}
51965196

51975197

51985198
void VerifySpkac(const FunctionCallbackInfo<Value>& args) {
5199-
bool i = false;
5199+
bool verify_result = false;
52005200

52015201
size_t length = Buffer::Length(args[0]);
52025202
if (length == 0)
5203-
return args.GetReturnValue().Set(i);
5203+
return args.GetReturnValue().Set(verify_result);
52045204

52055205
char* data = Buffer::Data(args[0]);
52065206
CHECK_NE(data, nullptr);
52075207

5208-
i = VerifySpkac(data, length);
5208+
verify_result = VerifySpkac(data, length);
52095209

5210-
args.GetReturnValue().Set(i);
5210+
args.GetReturnValue().Set(verify_result);
52115211
}
52125212

52135213

0 commit comments

Comments
 (0)
Please sign in to comment.