Skip to content

Commit c1e03ed

Browse files
addaleaxdanbev
authored andcommitted
src: use SealHandleScope for inspector tasks
This addresses a TODO comment that can be resolved, now that we have V8 7.4. PR-URL: #27116 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]>
1 parent f1ab837 commit c1e03ed

File tree

1 file changed

+1
-7
lines changed

1 file changed

+1
-7
lines changed

src/inspector/main_thread_interface.cc

+1-7
Original file line numberDiff line numberDiff line change
@@ -269,13 +269,7 @@ void MainThreadInterface::DispatchMessages() {
269269
std::swap(dispatching_message_queue_.front(), task);
270270
dispatching_message_queue_.pop_front();
271271

272-
// TODO(addaleax): The V8 inspector code currently sometimes allocates
273-
// handles that leak to the outside scope, rendering a HandleScope here
274-
// necessary. This handle scope can be removed/turned into a
275-
// SealHandleScope once/if
276-
// https://chromium-review.googlesource.com/c/v8/v8/+/1484304 makes it
277-
// into our copy of V8, maybe guarded with #ifdef DEBUG if we want.
278-
v8::HandleScope handle_scope(isolate_);
272+
v8::SealHandleScope seal_handle_scope(isolate_);
279273
task->Call(this);
280274
}
281275
} while (had_messages);

0 commit comments

Comments
 (0)