Skip to content

Commit c2aba5b

Browse files
Trottevanlucas
authored andcommitted
doc: consolidate test/lint text in GH PR template
PR-URL: #7155 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent e873063 commit c2aba5b

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
<!--
22
Thank you for your pull request. Please review below requirements.
33
4-
Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows.
5-
64
If this aims to fix a regression or you’re adding a feature, make sure you also
75
write a test. If possible, include a benchmark that quantifies your changes.
86
@@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
1311
##### Checklist
1412
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->
1513

16-
- [ ] tests and code linting passes
14+
- [ ] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes
1715
- [ ] a test and/or benchmark is included
1816
- [ ] documentation is changed or added
1917
- [ ] the commit message follows commit guidelines

0 commit comments

Comments
 (0)