Skip to content

Commit c388d11

Browse files
committed
test: fix flaky test-crypto-timing-safe-dqual-benchmarks
Fixes: #38226
1 parent 746cc88 commit c388d11

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

test/pummel/test-crypto-timing-safe-equal-benchmarks.js

+2-2
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function runOneBenchmark(compareFunc, firstBufFill, secondBufFill, bufSize) {
2727
}
2828

2929
function getTValue(compareFunc) {
30-
const numTrials = 1e5;
30+
const numTrials = 1e6;
3131
const bufSize = 10000;
3232
// Perform benchmarks to verify that timingSafeEqual is actually timing-safe.
3333

@@ -111,7 +111,7 @@ assert(
111111
`timingSafeEqual should not leak information from its execution time (t=${t})`
112112
);
113113

114-
// As a sanity check to make sure the statistical tests are working, run the
114+
// As a coherence check to make sure the statistical tests are working, run the
115115
// same benchmarks again, this time with an unsafe comparison function. In this
116116
// case the t-value should be above the threshold.
117117
const unsafeCompare = (bufA, bufB) => bufA.equals(bufB);

0 commit comments

Comments
 (0)