Skip to content

Commit c5181ed

Browse files
danbevMyles Borins
authored and
Myles Borins
committed
build: reduce noise from doc target
The doc target currently echos the complete shell command, which might produces a lot of output. Using this change the actual commands run are still shown. Before: [ -e tools/doc/node_modules/js-yaml/package.json ] || \ [ -e tools/eslint/node_modules/js-yaml/package.json ] || \ if [ -x ./node ]; then \ cd tools/doc && ../.././node ../.././deps/npm/bin/npm-cli.js install; \ else \ cd tools/doc && node ../.././deps/npm/bin/npm-cli.js install; \ fi [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md After: [ -x ./node ] && ./node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html || node tools/doc/generate.js --node-version=v8.0.0 --format=html --template=doc/template.html doc/api/assert.md > out/doc/api/assert.html Input file = doc/api/assert.md To verify run: $ make docclean $ make doc PR-URL: #9457 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: James Snell <[email protected]>
1 parent d3c25c1 commit c5181ed

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ out/doc/%: doc/%
284284
# check if ./node is actually set, else use user pre-installed binary
285285
gen-json = tools/doc/generate.js --format=json $< > $@
286286
out/doc/api/%.json: doc/api/%.md
287-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
287+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
288288
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
289289
if [ -x $(NODE) ]; then \
290290
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \
@@ -296,7 +296,7 @@ out/doc/api/%.json: doc/api/%.md
296296
# check if ./node is actually set, else use user pre-installed binary
297297
gen-html = tools/doc/generate.js --node-version=$(FULLVERSION) --format=html --template=doc/template.html $< > $@
298298
out/doc/api/%.html: doc/api/%.md
299-
[ -e tools/doc/node_modules/js-yaml/package.json ] || \
299+
@[ -e tools/doc/node_modules/js-yaml/package.json ] || \
300300
[ -e tools/eslint/node_modules/js-yaml/package.json ] || \
301301
if [ -x $(NODE) ]; then \
302302
cd tools/doc && ../../$(NODE) ../../$(NPM) install; \

0 commit comments

Comments
 (0)