Skip to content

Commit c572d2d

Browse files
F3n67udanielleadams
authored andcommitted
doc: use serial comma in pull request doc
PR-URL: #43319 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Akhil Marsonya <[email protected]>
1 parent 8a4e1fa commit c572d2d

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

doc/contributing/pull-requests.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ Node.js has many channels on the
4646
[OpenJS Foundation Slack](https://slack-invite.openjsf.org/). Interesting
4747
channels are:
4848
[#nodejs](https://openjs-foundation.slack.com/archives/CK9Q4MB53) for general
49-
help, questions and discussions.
49+
help, questions, and discussions.
5050
[#nodejs-dev](https://openjs-foundation.slack.com/archives/C019Y2T6STH) for
5151
development of Node.js core specifically.
5252

@@ -190,7 +190,7 @@ A good commit message should describe what changed and why.
190190

191191
5. If your commit introduces a breaking change (`semver-major`), it should
192192
contain an explanation about the reason of the breaking change, which
193-
situation would trigger the breaking change and what is the exact change.
193+
situation would trigger the breaking change, and what is the exact change.
194194

195195
Sample complete commit message:
196196

@@ -336,7 +336,7 @@ say so, or contact one of the other contributors in the project and seek their
336336
input. Often such comments are the result of the reviewer having only taken a
337337
short amount of time to review and are not ill-intended. Such issues can often
338338
be resolved with a bit of patience. That said, reviewers should be expected to
339-
be helpful in their feedback, and feedback that is simply vague, dismissive and
339+
be helpful in their feedback, and feedback that is simply vague, dismissive, and
340340
unhelpful is likely safe to ignore.
341341

342342
### Step 10: Landing
@@ -393,7 +393,7 @@ Focus first on the most significant aspects of the change:
393393
When changes are necessary, _request_ them, do not _demand_ them, and do not
394394
assume that the submitter already knows how to add a test or run a benchmark.
395395

396-
Specific performance optimization techniques, coding styles and conventions
396+
Specific performance optimization techniques, coding styles, and conventions
397397
change over time. The first impression you give to a new contributor never does.
398398

399399
Nits (requests for small changes that are not essential) are fine, but try to

0 commit comments

Comments
 (0)