@@ -46,7 +46,7 @@ Node.js has many channels on the
46
46
[ OpenJS Foundation Slack] ( https://slack-invite.openjsf.org/ ) . Interesting
47
47
channels are:
48
48
[ #nodejs] ( https://openjs-foundation.slack.com/archives/CK9Q4MB53 ) for general
49
- help, questions and discussions.
49
+ help, questions, and discussions.
50
50
[ #nodejs-dev] ( https://openjs-foundation.slack.com/archives/C019Y2T6STH ) for
51
51
development of Node.js core specifically.
52
52
@@ -190,7 +190,7 @@ A good commit message should describe what changed and why.
190
190
191
191
5 . If your commit introduces a breaking change (` semver-major ` ), it should
192
192
contain an explanation about the reason of the breaking change, which
193
- situation would trigger the breaking change and what is the exact change.
193
+ situation would trigger the breaking change, and what is the exact change.
194
194
195
195
Sample complete commit message:
196
196
@@ -336,7 +336,7 @@ say so, or contact one of the other contributors in the project and seek their
336
336
input. Often such comments are the result of the reviewer having only taken a
337
337
short amount of time to review and are not ill-intended. Such issues can often
338
338
be resolved with a bit of patience. That said, reviewers should be expected to
339
- be helpful in their feedback, and feedback that is simply vague, dismissive and
339
+ be helpful in their feedback, and feedback that is simply vague, dismissive, and
340
340
unhelpful is likely safe to ignore.
341
341
342
342
### Step 10: Landing
@@ -393,7 +393,7 @@ Focus first on the most significant aspects of the change:
393
393
When changes are necessary, _ request_ them, do not _ demand_ them, and do not
394
394
assume that the submitter already knows how to add a test or run a benchmark.
395
395
396
- Specific performance optimization techniques, coding styles and conventions
396
+ Specific performance optimization techniques, coding styles, and conventions
397
397
change over time. The first impression you give to a new contributor never does.
398
398
399
399
Nits (requests for small changes that are not essential) are fine, but try to
0 commit comments