Skip to content

Commit c5eb5bf

Browse files
jBarzBridgeAR
authored andcommitted
build: enable runtime linking
Enable runtime linking of shared objects. This will allow loading of symbols using the RTLD_GLOBAL flag. PR-URL: #15286 Fixes: #15243 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 3070d53 commit c5eb5bf

File tree

3 files changed

+3
-7
lines changed

3 files changed

+3
-7
lines changed

node.gyp

+1-1
Original file line numberDiff line numberDiff line change
@@ -784,7 +784,7 @@
784784
'common.gypi',
785785
],
786786

787-
'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp'],
787+
'ldflags': ['-Wl,-bE:<(PRODUCT_DIR)/node.exp', '-Wl,-brtl'],
788788
},
789789
{
790790
'target_name': 'node_exp',

test/addons/dlopen-ping-pong/binding.gyp

+2-3
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,9 @@
1010
'xcode_settings': {
1111
'OTHER_LDFLAGS': [ '-Wl,-undefined', '-Wl,dynamic_lookup' ]
1212
}}],
13-
# Pass erok flag to the linker, to prevent unresolved symbols
14-
# from failing. Still, the test won't pass, so we'll skip it on AIX.
13+
# Enable the shared object to be linked by runtime linker
1514
['OS=="aix"', {
16-
'ldflags': [ '-Wl,-berok' ]
15+
'ldflags': [ '-Wl,-G' ]
1716
}]],
1817
},
1918
{

test/addons/dlopen-ping-pong/test.js

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ const common = require('../../common');
44
if (common.isWindows)
55
common.skip('dlopen global symbol loading is not supported on this os.');
66

7-
if (common.isAIX)
8-
common.skip('this test does not pass on AIX.');
9-
107
const assert = require('assert');
118
const path = require('path');
129
const os = require('os');

0 commit comments

Comments
 (0)