Skip to content

Commit c68da89

Browse files
committed
build: always use V8_ENABLE_CHECKS in debug mode
Define `V8_ENABLE_CHECKS` in `common.gypi` for the debug mode. Without this, these checks would only be present in the object files generated from the V8 build, and so for inline functions in v8.h multiple different definitions could be generated, where one definition includes the check and the other does not. Refs: #11975 (comment) PR-URL: #12029 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Jason Ginchereau <[email protected]> Reviewed-By: Hitesh Kanwathirtha <[email protected]>
1 parent 241de51 commit c68da89

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
'variables': {
7979
'v8_enable_handle_zapping': 1,
8080
},
81-
'defines': [ 'DEBUG', '_DEBUG' ],
81+
'defines': [ 'DEBUG', '_DEBUG', 'V8_ENABLE_CHECKS' ],
8282
'cflags': [ '-g', '-O0' ],
8383
'conditions': [
8484
['target_arch=="x64"', {

0 commit comments

Comments
 (0)