Skip to content

Commit c776c92

Browse files
targosdanielleadams
authored andcommitted
build: re-enable V8 concurrent marking
It was unintentionally disabled during a V8 update. Fixes: #41012 PR-URL: #41013 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent dc0405e commit c776c92

File tree

2 files changed

+19
-6
lines changed

2 files changed

+19
-6
lines changed

tools/v8_gypfiles/features.gypi

+16
Original file line numberDiff line numberDiff line change
@@ -147,6 +147,16 @@
147147
# Sets -dV8_TRACE_FEEDBACK_UPDATES.
148148
'v8_enable_trace_feedback_updates%': 0,
149149

150+
# Sets -dV8_ATOMIC_OBJECT_FIELD_WRITES and turns all field write operations
151+
# into relaxed atomic operations.
152+
'v8_enable_atomic_object_field_writes%': 1,
153+
154+
# Sets -dV8_ATOMIC_MARKING_STATE
155+
'v8_enable_atomic_marking_state%': 1,
156+
157+
# Has no effect in Node.js. Here for completeness with V8's config.
158+
'v8_enable_concurrent_marking%': 1,
159+
150160
# Enables various testing features.
151161
'v8_enable_test_features%': 0,
152162

@@ -343,6 +353,12 @@
343353
['v8_enable_third_party_heap==1', {
344354
'defines': ['V8_ENABLE_THIRD_PARTY_HEAP',],
345355
}],
356+
['v8_enable_atomic_object_field_writes==1', {
357+
'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',],
358+
}],
359+
['v8_enable_atomic_marking_state==1', {
360+
'defines': ['V8_ATOMIC_MARKING_STATE',],
361+
}],
346362
['v8_enable_lazy_source_positions==1', {
347363
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
348364
}],

tools/v8_gypfiles/v8.gyp

+3-6
Original file line numberDiff line numberDiff line change
@@ -1713,12 +1713,9 @@
17131713
'is_ubsan_vptr=0',
17141714
'target_cpu=<(target_arch)',
17151715
'v8_current_cpu=<(v8_current_cpu)',
1716-
# Not available in gyp.
1717-
'v8_enable_atomic_marking_state=0',
1718-
# Not available in gyp.
1719-
'v8_enable_atomic_object_field_writes=0',
1720-
# Not available in gyp.
1721-
'v8_enable_concurrent_marking=0',
1716+
'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)',
1717+
'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)',
1718+
'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)',
17221719
'v8_enable_i18n_support=<(v8_enable_i18n_support)',
17231720
'v8_enable_verify_predictable=<(v8_enable_verify_predictable)',
17241721
'v8_enable_verify_csa=<(v8_enable_verify_csa)',

0 commit comments

Comments
 (0)