Skip to content

Commit c9d5be4

Browse files
committed
test: fix flaky test-make-doc
`test-make-doc` fails in CI on Raspberry Pi devices where `test-ci-js` runs the test but does not build the docs. We do not want to build the docs in these cases. Move the test to the `doctool` suite and add that suite to `IGNORED_SUITES` in `test.py`. Specify `doctool` as a test suite to run with `make test` or `make test-ci` but not with the `make test-ci-js` job run on cross-compiled fanned CI tests like we do with Raspberry Pi devices in CI. PR-URL: #16301 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 33b4320 commit c9d5be4

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ test: all
214214
$(CI_ASYNC_HOOKS) \
215215
$(CI_JS_SUITES) \
216216
$(CI_NATIVE_SUITES) \
217-
known_issues
217+
doctool known_issues
218218
$(MAKE) lint
219219
endif
220220

@@ -392,7 +392,7 @@ test-ci: | clear-stalled build-addons build-addons-napi doc
392392
out/Release/cctest --gtest_output=tap:cctest.tap
393393
$(PYTHON) tools/test.py $(PARALLEL_ARGS) -p tap --logfile test.tap \
394394
--mode=release --flaky-tests=$(FLAKY_TESTS) \
395-
$(TEST_CI_ARGS) $(CI_ASYNC_HOOKS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) known_issues
395+
$(TEST_CI_ARGS) $(CI_ASYNC_HOOKS) $(CI_JS_SUITES) $(CI_NATIVE_SUITES) doctool known_issues
396396
# Clean up any leftover processes, error if found.
397397
ps awwx | grep Release/node | grep -v grep | cat
398398
@PS_OUT=`ps awwx | grep Release/node | grep -v grep | awk '{print $$1}'`; \
File renamed without changes.

tools/test.py

+1
Original file line numberDiff line numberDiff line change
@@ -1555,6 +1555,7 @@ def PrintCrashed(code):
15551555
IGNORED_SUITES = [
15561556
'addons',
15571557
'addons-napi',
1558+
'doctool',
15581559
'gc',
15591560
'internet',
15601561
'pummel',

0 commit comments

Comments
 (0)