Skip to content

Commit c9f8d28

Browse files
refacktargos
authored andcommitted
deps: V8: fix BUILDING_V8_SHARED issues
Backport-PR-URL: #28955 PR-URL: #27375 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Ujjwal Sharma <[email protected]> Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent f24caef commit c9f8d28

File tree

4 files changed

+7
-1
lines changed

4 files changed

+7
-1
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.8',
41+
'v8_embedder_string': '-node.9',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/init/setup-isolate-deserialize.cc

+1
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
#include "src/base/logging.h"
88
#include "src/execution/isolate.h"
99
#include "src/interpreter/interpreter.h"
10+
#include "src/objects/objects-inl.h"
1011
#include "src/utils/ostreams.h"
1112

1213
namespace v8 {

deps/v8/src/objects/ordered-hash-table.cc

+4
Original file line numberDiff line numberDiff line change
@@ -930,6 +930,7 @@ OrderedHashTableHandler<SmallOrderedNameDictionary,
930930
OrderedNameDictionary>::Allocate(Isolate* isolate,
931931
int capacity);
932932

933+
#if !defined(V8_OS_WIN)
933934
template <class SmallTable, class LargeTable>
934935
bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
935936
Handle<HeapObject> table, Handle<Object> key) {
@@ -942,7 +943,9 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::Delete(
942943
// down to a smaller hash table.
943944
return LargeTable::Delete(Handle<LargeTable>::cast(table), key);
944945
}
946+
#endif
945947

948+
#if !defined(V8_OS_WIN)
946949
template <class SmallTable, class LargeTable>
947950
bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
948951
Isolate* isolate, Handle<HeapObject> table, Handle<Object> key) {
@@ -953,6 +956,7 @@ bool OrderedHashTableHandler<SmallTable, LargeTable>::HasKey(
953956
DCHECK(LargeTable::Is(table));
954957
return LargeTable::HasKey(isolate, LargeTable::cast(*table), *key);
955958
}
959+
#endif
956960

957961
template bool
958962
OrderedHashTableHandler<SmallOrderedHashSet, OrderedHashSet>::HasKey(

deps/v8/src/snapshot/snapshot.h

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
#include "src/snapshot/partial-serializer.h"
99
#include "src/snapshot/startup-serializer.h"
1010

11+
#include "src/objects/objects-inl.h"
1112
#include "src/utils/utils.h"
1213

1314
namespace v8 {

0 commit comments

Comments
 (0)