Skip to content

Commit cb69811

Browse files
addaleaxtargos
authored andcommitted
src: add comment on CallbackScope exception behaviour
PR-URL: #21743 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Shelley Vohr <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
1 parent 0de0f89 commit cb69811

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

src/node.h

+4
Original file line numberDiff line numberDiff line change
@@ -683,6 +683,10 @@ class InternalCallbackScope;
683683
*
684684
* This object should be stack-allocated to ensure that it is contained in a
685685
* valid HandleScope.
686+
*
687+
* Exceptions happening within this scope will be treated like uncaught
688+
* exceptions. If this behaviour is undesirable, a new `v8::TryCatch` scope
689+
* needs to be created inside of this scope.
686690
*/
687691
class NODE_EXTERN CallbackScope {
688692
public:

0 commit comments

Comments
 (0)