Skip to content

Commit cb7f73c

Browse files
Trottdanielleadams
authored andcommitted
tools: revise line in configure.py for clarity
* Replace unused identifier with Python convention `_`. * Remove unneeded parentheses. * Remove line-wrapping. I confirmed that this doesn't change the output by running `./configure --shared-zlib` and confirming that it created the same `common.gypi` with and without these changes. The code changed here doesn't run unless there is a `--shared-*` flag. PR-URL: #36551 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]>
1 parent 3170636 commit cb7f73c

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

configure.py

+1-2
Original file line numberDiff line numberDiff line change
@@ -1347,8 +1347,7 @@ def configure_library(lib, output, pkgname=None):
13471347
output['variables']['node_' + shared_lib] = b(getattr(options, shared_lib))
13481348

13491349
if getattr(options, shared_lib):
1350-
(pkg_libs, pkg_cflags, pkg_libpath, pkg_modversion) = (
1351-
pkg_config(pkgname or lib))
1350+
(pkg_libs, pkg_cflags, pkg_libpath, _) = pkg_config(pkgname or lib)
13521351

13531352
if options.__dict__[shared_lib + '_includes']:
13541353
output['include_dirs'] += [options.__dict__[shared_lib + '_includes']]

0 commit comments

Comments
 (0)