Skip to content

Commit cdc7a19

Browse files
Trotttargos
authored andcommitted
test: remove common.enoughTestCpu
All hosts in CI return true for common.enoughTestCpu. At least for our CI, it is always true, so we can remove it. PR-URL: #39161 Reviewed-By: Luigi Pinca <[email protected]>
1 parent bd472da commit cdc7a19

9 files changed

+0
-33
lines changed

Diff for: test/common/README.md

-7
Original file line numberDiff line numberDiff line change
@@ -62,13 +62,6 @@ On non-Windows platforms, this always returns `true`.
6262

6363
Creates a 10 MB file of all null characters.
6464

65-
### `enoughTestCpu`
66-
67-
* [&lt;boolean>][]
68-
69-
Indicates if there is more than 1 CPU or that the single CPU has a speed of at
70-
least 1 GHz.
71-
7265
### `enoughTestMem`
7366

7467
* [&lt;boolean>][]

Diff for: test/common/index.js

-5
Original file line numberDiff line numberDiff line change
@@ -788,11 +788,6 @@ const common = {
788788
skipIfInspectorDisabled,
789789
skipIfWorker,
790790

791-
get enoughTestCpu() {
792-
const cpus = require('os').cpus();
793-
return Array.isArray(cpus) && (cpus.length > 1 || cpus[0].speed > 999);
794-
},
795-
796791
get enoughTestMem() {
797792
return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
798793
},

Diff for: test/common/index.mjs

-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const {
1818
isLinux,
1919
isOSX,
2020
enoughTestMem,
21-
enoughTestCpu,
2221
buildType,
2322
localIPv6Hosts,
2423
opensslCli,
@@ -64,7 +63,6 @@ export {
6463
isLinux,
6564
isOSX,
6665
enoughTestMem,
67-
enoughTestCpu,
6866
buildType,
6967
localIPv6Hosts,
7068
opensslCli,

Diff for: test/pummel/test-fs-watch-system-limit.js

-4
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,6 @@ if (!common.isLinux) {
99
common.skip('The fs watch limit is OS-dependent');
1010
}
1111

12-
if (!common.enoughTestCpu) {
13-
common.skip('This test is resource-intensive');
14-
}
15-
1612
if ((process.config.variables.arm_version === '6') ||
1713
(process.config.variables.arm_version === '7')) {
1814
common.skip('Too slow for armv6 and armv7 bots');

Diff for: test/tick-processor/test-tick-processor-builtin.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
const common = require('../common');
33
const { isCPPSymbolsNotMapped } = require('./util');
44

5-
if (!common.enoughTestCpu)
6-
common.skip('test is CPU-intensive');
7-
85
if (isCPPSymbolsNotMapped) {
96
common.skip('C++ symbols are not mapped for this os.');
107
}

Diff for: test/tick-processor/test-tick-processor-cpp-core.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
const common = require('../common');
33
const { isCPPSymbolsNotMapped } = require('./util');
44

5-
if (!common.enoughTestCpu)
6-
common.skip('test is CPU-intensive');
7-
85
if (isCPPSymbolsNotMapped) {
96
common.skip('C++ symbols are not mapped for this os.');
107
}

Diff for: test/tick-processor/test-tick-processor-polyfill-brokenfile.js

-3
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@ const { isCPPSymbolsNotMapped } = require('./util');
44
const tmpdir = require('../common/tmpdir');
55
tmpdir.refresh();
66

7-
if (!common.enoughTestCpu)
8-
common.skip('test is CPU-intensive');
9-
107
if (isCPPSymbolsNotMapped) {
118
common.skip('C++ symbols are not mapped for this OS.');
129
}

Diff for: test/tick-processor/test-tick-processor-preprocess-flag.js

-3
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@
22
const common = require('../common');
33
const { isCPPSymbolsNotMapped } = require('./util');
44

5-
if (!common.enoughTestCpu)
6-
common.skip('test is CPU-intensive');
7-
85
if (isCPPSymbolsNotMapped) {
96
common.skip('C++ symbols are not mapped for this os.');
107
}

Diff for: test/tick-processor/test-tick-processor-unknown.js

-3
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,6 @@ const common = require('../common');
99
if (common.isAIX)
1010
common.skip('AIX address range too big for scripts.');
1111

12-
if (!common.enoughTestCpu)
13-
common.skip('test is CPU-intensive');
14-
1512
const base = require('./tick-processor-base.js');
1613

1714
// Unknown checked for to prevent flakiness, if pattern is not found,

0 commit comments

Comments
 (0)