Skip to content

Commit cdcc82c

Browse files
committed
deps: silence V8's warning on CompileFunction
We are not ready to migrate yet. Refs: nodejs/node-v8#214 PR-URL: #40907 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rich Trott <[email protected]>
1 parent 2d2cef1 commit cdcc82c

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

common.gypi

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636

3737
# Reset this number to 0 on major V8 upgrades.
3838
# Increment by one for each non-official patch applied to deps/v8.
39-
'v8_embedder_string': '-node.4',
39+
'v8_embedder_string': '-node.5',
4040

4141
##### V8 defaults for Node.js #####
4242

deps/v8/include/v8-script.h

-1
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,6 @@ class V8_EXPORT ScriptCompiler {
650650
* It is possible to specify multiple context extensions (obj in the above
651651
* example).
652652
*/
653-
V8_DEPRECATED("Use CompileFunction")
654653
static V8_WARN_UNUSED_RESULT MaybeLocal<Function> CompileFunctionInContext(
655654
Local<Context> context, Source* source, size_t arguments_count,
656655
Local<String> arguments[], size_t context_extension_count,

0 commit comments

Comments
 (0)