Skip to content

Commit ce7fad5

Browse files
danbevtargos
authored andcommitted
src: use unique_ptr for obj in SetWeak lambda
PR-URL: #23117 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 23525b0 commit ce7fad5

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

src/base_object-inl.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -95,13 +95,12 @@ void BaseObject::MakeWeak() {
9595
persistent_handle_.SetWeak(
9696
this,
9797
[](const v8::WeakCallbackInfo<BaseObject>& data) {
98-
BaseObject* obj = data.GetParameter();
98+
std::unique_ptr<BaseObject> obj(data.GetParameter());
9999
// Clear the persistent handle so that ~BaseObject() doesn't attempt
100100
// to mess with internal fields, since the JS object may have
101101
// transitioned into an invalid state.
102102
// Refs: https://github.com/nodejs/node/issues/18897
103103
obj->persistent_handle_.Reset();
104-
delete obj;
105104
}, v8::WeakCallbackType::kParameter);
106105
}
107106

0 commit comments

Comments
 (0)