Skip to content

Commit cf89100

Browse files
Trotttargos
authored andcommitted
doc: update GOVERNANCE.md
This consists of some hopefully-uncontroversial simplifications/clarifications to the text. The one substantial change is to update Node.js Board of Directors to be the OpenJS Board of Directors. PR-URL: #30259 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Christian Clauss <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 29c8199 commit cf89100

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

GOVERNANCE.md

+16-20
Original file line numberDiff line numberDiff line change
@@ -15,22 +15,21 @@
1515
## Collaborators
1616

1717
Node.js Core Collaborators maintain the [nodejs/node][] GitHub repository.
18-
The GitHub team for Node.js Core Collaborators is @nodejs/collaborators. Their
19-
privileges include but are not limited to:
18+
The GitHub team for Node.js Core Collaborators is @nodejs/collaborators.
19+
Collaborators have:
2020

2121
* Commit access to the [nodejs/node][] repository
2222
* Access to the Node.js continuous integration (CI) jobs
2323

2424
Both Collaborators and non-Collaborators may propose changes to the Node.js
2525
source code. The mechanism to propose such a change is a GitHub pull request.
26-
Collaborators are responsible for reviewing and merging (_landing_)
27-
pull requests.
26+
Collaborators review and merge (_land_) pull requests.
2827

29-
At least two Collaborators must approve a pull request before the pull request
30-
can land. (One Collaborator approval is enough if the pull request has been open
31-
for more than 7 days.) Approving a pull request indicates that the Collaborator
32-
accepts responsibility for the change. Approval must be from Collaborators who
33-
are not authors of the change.
28+
Two Collaborators must approve a pull request before the pull request can land.
29+
(One Collaborator approval is enough if the pull request has been open for more
30+
than 7 days.) Approving a pull request indicates that the Collaborator accepts
31+
responsibility for the change. Approval must be from Collaborators who are not
32+
authors of the change.
3433

3534
If a Collaborator opposes a proposed change, then the change cannot land. The
3635
exception is if the TSC votes to approve the change despite the opposition.
@@ -39,13 +38,11 @@ result in Collaborators removing their opposition.
3938

4039
See:
4140

42-
* [Current list of Collaborators](./README.md#current-project-team-members)
41+
* [List of Collaborators](./README.md#current-project-team-members)
4342
* [A guide for Collaborators](./COLLABORATOR_GUIDE.md)
4443

4544
### Collaborator Activities
4645

47-
Typical activities of a Collaborator include:
48-
4946
* Helping users and novice contributors
5047
* Contributing code and documentation changes that improve the project
5148
* Reviewing and commenting on issues and pull requests
@@ -71,7 +68,7 @@ The current list of TSC members is in
7168
[the project README](./README.md#current-project-team-members).
7269

7370
The [TSC Charter][] governs the operations of the TSC. All changes to the
74-
Charter need approval by the Node.js Board of Directors.
71+
Charter need approval by the OpenJS Foundation Board of Directors.
7572

7673
### TSC Meetings
7774

@@ -124,7 +121,7 @@ Provide a summary of the nominee's contributions. For example:
124121
* Use the link `https://github.com/nodejs/node/issues?q=commenter:GITHUB_ID`
125122
* Reviews on pull requests in the [nodejs/node][] repository
126123
* Use the link `https://github.com/nodejs/node/pulls?q=reviewed-by:GITHUB_ID`
127-
* Help provided to end users and novice contributors
124+
* Help provided to end-users and novice contributors
128125
* Pull requests and issues opened throughout the Node.js organization
129126
* Use the link `https://github.com/search?q=author:GITHUB_ID+org:nodejs`
130127
* Comments on pull requests and issues throughout the Node.js organization
@@ -144,16 +141,15 @@ frictionless as possible. Use the [Collaborators discussion page][] to request
144141
feedback from other Collaborators in private. A nominator may also work with the
145142
nominee to improve their contribution profile.
146143

147-
It is possible that Collaborators will overlook someone with valuable
148-
contributions. In that case, the contributor may open an issue or contact a
149-
Collaborator to request a nomination.
144+
Collaborators might overlook someone with valuable contributions. In that case,
145+
the contributor may open an issue or contact a Collaborator to request a
146+
nomination.
150147

151148
### Onboarding
152149

153150
After the nomination passes, a TSC member onboards the new Collaborator. See
154-
[the onboarding guide](./doc/onboarding.md) on details of the onboarding
155-
process. In general, the onboarding should occur within a month after the
156-
nomination passes.
151+
[the onboarding guide](./doc/onboarding.md) for details of the onboarding
152+
process.
157153

158154
## Consensus Seeking Process
159155

0 commit comments

Comments
 (0)