Skip to content

Commit cfdcd6c

Browse files
alexkozyjasnell
authored andcommitted
v8: backport 43791ce02c8 from upstream v8
Original commit message: [PATCH] [inspector] finally removed *ExecuteScript from inspector We don't need hints from embedder any more. BUG=none [email protected] Review-Url: https://codereview.chromium.org/2773143002 Cr-Commit-Position: refs/heads/master@{#44158} PR-URL: #13217 Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 1061e43 commit cfdcd6c

File tree

3 files changed

+0
-19
lines changed

3 files changed

+0
-19
lines changed

deps/v8/include/v8-inspector.h

-2
Original file line numberDiff line numberDiff line change
@@ -224,8 +224,6 @@ class V8_EXPORT V8Inspector {
224224
virtual void resetContextGroup(int contextGroupId) = 0;
225225

226226
// Various instrumentation.
227-
virtual void willExecuteScript(v8::Local<v8::Context>, int scriptId) = 0;
228-
virtual void didExecuteScript(v8::Local<v8::Context>) = 0;
229227
virtual void idleStarted() = 0;
230228
virtual void idleFinished() = 0;
231229

deps/v8/src/inspector/v8-inspector-impl.cc

-15
Original file line numberDiff line numberDiff line change
@@ -285,21 +285,6 @@ void V8InspectorImpl::resetContextGroup(int contextGroupId) {
285285
m_debugger->wasmTranslation()->Clear();
286286
}
287287

288-
void V8InspectorImpl::willExecuteScript(v8::Local<v8::Context> context,
289-
int scriptId) {
290-
if (V8DebuggerAgentImpl* agent =
291-
enabledDebuggerAgentForGroup(contextGroupId(context))) {
292-
agent->willExecuteScript(scriptId);
293-
}
294-
}
295-
296-
void V8InspectorImpl::didExecuteScript(v8::Local<v8::Context> context) {
297-
if (V8DebuggerAgentImpl* agent =
298-
enabledDebuggerAgentForGroup(contextGroupId(context))) {
299-
agent->didExecuteScript();
300-
}
301-
}
302-
303288
void V8InspectorImpl::idleStarted() {
304289
for (auto it = m_sessions.begin(); it != m_sessions.end(); ++it) {
305290
if (it->second->profilerAgent()->idleStarted()) return;

deps/v8/src/inspector/v8-inspector-impl.h

-2
Original file line numberDiff line numberDiff line change
@@ -85,8 +85,6 @@ class V8InspectorImpl : public V8Inspector {
8585
void contextCreated(const V8ContextInfo&) override;
8686
void contextDestroyed(v8::Local<v8::Context>) override;
8787
void resetContextGroup(int contextGroupId) override;
88-
void willExecuteScript(v8::Local<v8::Context>, int scriptId) override;
89-
void didExecuteScript(v8::Local<v8::Context>) override;
9088
void idleStarted() override;
9189
void idleFinished() override;
9290
unsigned exceptionThrown(v8::Local<v8::Context>, const StringView& message,

0 commit comments

Comments
 (0)