Skip to content

Commit d070f5d

Browse files
BridgeARZYSzys
authored andcommitted
worker: improve coverage
This improves the worker coverage by using `internal/assert` instead of relying on `assert` in case a faulty worker message type is received. PR-URL: #27230 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Yongsheng Zhang <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
1 parent 5450e48 commit d070f5d

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

lib/internal/main/worker_thread.js

+7-6
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,8 @@ const {
4545

4646
const publicWorker = require('worker_threads');
4747

48+
const assert = require('internal/assert');
49+
4850
patchProcessObject();
4951
setupInspectorHooks();
5052
setupDebugEnv();
@@ -122,18 +124,17 @@ port.on('message', (message) => {
122124
process.argv[1] = filename; // script filename
123125
require('module').runMain();
124126
}
125-
return;
126127
} else if (message.type === STDIO_PAYLOAD) {
127128
const { stream, chunk, encoding } = message;
128129
process[stream].push(chunk, encoding);
129-
return;
130-
} else if (message.type === STDIO_WANTS_MORE_DATA) {
130+
} else {
131+
assert(
132+
message.type === STDIO_WANTS_MORE_DATA,
133+
`Unknown worker message type ${message.type}`
134+
);
131135
const { stream } = message;
132136
process[stream][kStdioWantsMoreDataCallback]();
133-
return;
134137
}
135-
136-
require('assert').fail(`Unknown worker message type ${message.type}`);
137138
});
138139

139140
// Overwrite fatalException

0 commit comments

Comments
 (0)