Skip to content

Commit d0e4e2b

Browse files
MSLaguanaaddaleax
authored andcommitted
test: fix cctest failure on Windows
Linux converts the ipv6 address "::" to "::1", while windows does not. By explicitly using "::1" in the test we allow it to succeed on windows. PR-URL: #14111 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Eugene Ostroukhov <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Kunal Pathak <[email protected]> Reviewed-By: João Reis <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent cfa5e0c commit d0e4e2b

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/cctest/test_inspector_socket_server.cc

+1-1
Original file line numberDiff line numberDiff line change
@@ -621,7 +621,7 @@ TEST_F(InspectorSocketServerTest, BindsToIpV6) {
621621
ASSERT_TRUE(server->Start());
622622

623623
SocketWrapper socket1(&loop);
624-
socket1.Connect("::", server.port(), true);
624+
socket1.Connect("::1", server.port(), true);
625625
socket1.Write(WsHandshakeRequest(MAIN_TARGET_ID));
626626
socket1.Expect(WS_HANDSHAKE_RESPONSE);
627627
server->Stop(ServerHolder::CloseCallback);

0 commit comments

Comments
 (0)