File tree 1 file changed +7
-6
lines changed
1 file changed +7
-6
lines changed Original file line number Diff line number Diff line change @@ -184,14 +184,15 @@ Landing a PR
184
184
* close the original PR with "Landed in ` <commit hash> ` ".
185
185
186
186
187
- ## exercise: make PRs adding yourselves to the README
187
+ ## Exercise: Make a PR adding yourself to the README
188
188
189
189
* Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732
190
- * to see full URL: ` git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1 `
191
- * Collaborators in alphabetical order by username
192
- * Label your pull request with the ` doc ` subsystem label
193
- * If you would like to run CI on your PR, feel free to
194
- * Make sure to added the ` PR-URL: <full-pr-url> ` !
190
+ * For raw commit message: ` git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1 `
191
+ * Collaborators are in alphabetical order by GitHub username.
192
+ * Label your pull request with the ` doc ` subsystem label.
193
+ * Run CI on your PR.
194
+ * After a ` LGTM ` or two, land the PR.
195
+ * Be sure to add the ` PR-URL: <full-pr-url> ` and appropriate ` Reviewed-By: ` metadata!
195
196
196
197
197
198
## final notes
You can’t perform that action at this time.
0 commit comments