Skip to content

Commit d123fc1

Browse files
TrottMylesBorins
authored andcommitted
doc: update exercise portion of onboarding doc
PR-URL: #8559 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Ilkka Myller <[email protected]>
1 parent 5a07bb6 commit d123fc1

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

doc/onboarding.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -184,14 +184,15 @@ Landing a PR
184184
* close the original PR with "Landed in `<commit hash>`".
185185

186186

187-
## exercise: make PRs adding yourselves to the README
187+
## Exercise: Make a PR adding yourself to the README
188188

189189
* Example: https://github.com/nodejs/node/commit/7b09aade8468e1c930f36b9c81e6ac2ed5bc8732
190-
* to see full URL: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1`
191-
* Collaborators in alphabetical order by username
192-
* Label your pull request with the `doc` subsystem label
193-
* If you would like to run CI on your PR, feel free to
194-
* Make sure to added the `PR-URL: <full-pr-url>`!
190+
* For raw commit message: `git log 7b09aade8468e1c930f36b9c81e6ac2ed5bc8732 -1`
191+
* Collaborators are in alphabetical order by GitHub username.
192+
* Label your pull request with the `doc` subsystem label.
193+
* Run CI on your PR.
194+
* After a `LGTM` or two, land the PR.
195+
* Be sure to add the `PR-URL: <full-pr-url>` and appropriate `Reviewed-By:` metadata!
195196

196197

197198
## final notes

0 commit comments

Comments
 (0)