Skip to content

Commit d23c49f

Browse files
bmeckaddaleax
authored andcommitted
url: do not use HandleScope in ToObject
It is not needed / invalidates the returned value unlike EscapableHandleScope PR-URL: #14096 Reviewed-By: Refael Ackermann <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 784102f commit d23c49f

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node_url.cc

-1
Original file line numberDiff line numberDiff line change
@@ -2085,7 +2085,6 @@ static void DomainToUnicode(const FunctionCallbackInfo<Value>& args) {
20852085
const Local<Value> URL::ToObject(Environment* env) const {
20862086
Isolate* isolate = env->isolate();
20872087
Local<Context> context = env->context();
2088-
HandleScope handle_scope(isolate);
20892088
Context::Scope context_scope(context);
20902089

20912090
const Local<Value> undef = Undefined(isolate);

0 commit comments

Comments
 (0)