src: get binding data store directly from the realm

We now store the binding data store in the realm and invoke
`Realm::AddBindingData` to add the binding data, so there is no
need to get a reference to the binding data store from the context
now, we can just get the reference from the realm.

PR-URL: #47437
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: James M Snell <[email protected]>

Author: joyeecheung

src/node_realm-inl.h

@@ -88,14 +88,14 @@ inline T* Realm::AddBindingData(v8::Local<v8::Context> context,
   // This won't compile if T is not a BaseObject subclass.
   BaseObjectPtr<T> item =
       MakeDetachedBaseObject<T>(this, target, std::forward<Args>(args)...);
-  BindingDataStore* map =
-      static_cast<BindingDataStore*>(context->GetAlignedPointerFromEmbedderData(
-          ContextEmbedderIndex::kBindingDataStoreIndex));
-  DCHECK_NOT_NULL(map);
+  DCHECK_EQ(context->GetAlignedPointerFromEmbedderData(
+                ContextEmbedderIndex::kBindingDataStoreIndex),
+            &binding_data_store_);
   constexpr size_t binding_index = static_cast<size_t>(T::binding_type_int);
   static_assert(binding_index < std::tuple_size_v<BindingDataStore>);
-  CHECK(!(*map)[binding_index]);  // Should not insert the binding twice.
-  (*map)[binding_index] = item;
+  // Should not insert the binding twice.
+  CHECK(!binding_data_store_[binding_index]);
+  binding_data_store_[binding_index] = item;
   DCHECK_EQ(GetBindingData<T>(context), item.get());
   return item.get();
 }