Skip to content

Commit d38ce82

Browse files
Trotttargos
authored andcommitted
test: remove common.hasSmallICU
common.hasSmallICU is used in only one test and is a one-liner. Move into the test where it is used to chip away at the `common` monolith. PR-URL: #22937 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>
1 parent ace6e07 commit d38ce82

File tree

3 files changed

+4
-9
lines changed

3 files changed

+4
-9
lines changed

test/common/README.md

-5
Original file line numberDiff line numberDiff line change
@@ -158,11 +158,6 @@ Indicates `hasCrypto` and `crypto` with fips.
158158

159159
Indicates if [internationalization] is supported.
160160

161-
### hasSmallICU
162-
* [&lt;boolean>]
163-
164-
Indicates `hasIntl` and `small-icu` are supported.
165-
166161
### hasIPv6
167162
* [&lt;boolean>]
168163

test/common/index.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,7 @@ const { fixturesDir } = require('./fixtures');
3333
const tmpdir = require('./tmpdir');
3434
const {
3535
bits,
36-
hasIntl,
37-
hasSmallICU
36+
hasIntl
3837
} = process.binding('config');
3938

4039
const noop = () => {};
@@ -712,7 +711,6 @@ module.exports = {
712711
hasIntl,
713712
hasCrypto,
714713
hasIPv6,
715-
hasSmallICU,
716714
hasMultiLocalhost,
717715
isAIX,
718716
isAlive,

test/parallel/test-icu-data-dir.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
'use strict';
22
const common = require('../common');
33
const os = require('os');
4-
if (!(common.hasIntl && common.hasSmallICU))
4+
5+
const { hasSmallICU } = process.binding('config');
6+
if (!(common.hasIntl && hasSmallICU))
57
common.skip('missing Intl');
68

79
const assert = require('assert');

0 commit comments

Comments
 (0)