Skip to content

Commit d4934ae

Browse files
committedJan 4, 2019
lib: move DEP0006 to end of life
This commit moves DEP0006, which has been runtime deprecated since Node 0.11, to end of life status. PR-URL: #25279 Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]>
1 parent 7d453ff commit d4934ae

File tree

3 files changed

+5
-67
lines changed

3 files changed

+5
-67
lines changed
 

‎doc/api/deprecations.md

+4-1
Original file line numberDiff line numberDiff line change
@@ -160,6 +160,9 @@ outside `node_modules` in order to better target developers, rather than users.
160160
### DEP0006: child\_process options.customFds
161161
<!-- YAML
162162
changes:
163+
- version: REPLACEME
164+
pr-url: https://github.com/nodejs/node/pull/25279
165+
description: End-of-Life.
163166
- version:
164167
- v4.8.6
165168
- v6.12.0
@@ -171,7 +174,7 @@ changes:
171174
description: Documentation-only deprecation.
172175
-->
173176

174-
Type: Runtime
177+
Type: End-of-Life
175178

176179
Within the [`child_process`][] module's `spawn()`, `fork()`, and `exec()`
177180
methods, the `options.customFds` option is deprecated. The `options.stdio`

‎lib/child_process.js

+1-19
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,7 @@
2222
'use strict';
2323

2424
const util = require('util');
25-
const {
26-
deprecate, convertToValidSignal, getSystemErrorName
27-
} = require('internal/util');
25+
const { convertToValidSignal, getSystemErrorName } = require('internal/util');
2826
const { isArrayBufferView } = require('internal/util/types');
2927
const debug = util.debuglog('child_process');
3028
const { Buffer } = require('buffer');
@@ -384,20 +382,6 @@ Object.defineProperty(exports.execFile, util.promisify.custom, {
384382
value: customPromiseExecFunction(exports.execFile)
385383
});
386384

387-
const _deprecatedCustomFds = deprecate(
388-
function deprecateCustomFds(options) {
389-
options.stdio = options.customFds.map(function mapCustomFds(fd) {
390-
return fd === -1 ? 'pipe' : fd;
391-
});
392-
}, 'child_process: options.customFds option is deprecated. ' +
393-
'Use options.stdio instead.', 'DEP0006');
394-
395-
function _convertCustomFds(options) {
396-
if (options.customFds && !options.stdio) {
397-
_deprecatedCustomFds(options);
398-
}
399-
}
400-
401385
function normalizeSpawnArguments(file, args, options) {
402386
validateString(file, 'file');
403387

@@ -526,8 +510,6 @@ function normalizeSpawnArguments(file, args, options) {
526510
}
527511
}
528512

529-
_convertCustomFds(options);
530-
531513
return {
532514
file: file,
533515
args: args,

‎test/parallel/test-child-process-custom-fds.js

-47
This file was deleted.

0 commit comments

Comments
 (0)
Please sign in to comment.