Skip to content

Commit d4a8631

Browse files
mscdexaddaleax
authored andcommitted
build: fix newlines in addon build output
Interpretation of escape sequences with echo is not as consistent across platforms as printf, so use the latter instead. PR-URL: #11466 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>
1 parent 4f6a3d3 commit d4a8631

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Makefile

+1-1
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ test/addons/.buildstamp: config.gypi \
238238
# Cannot use $(wildcard test/addons/*/) here, it's evaluated before
239239
# embedded addons have been generated from the documentation.
240240
@for dirname in test/addons/*/; do \
241-
echo "\nBuilding addon $$PWD/$$dirname" ; \
241+
printf "\nBuilding addon $$PWD/$$dirname\n" ; \
242242
env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \
243243
--loglevel=$(LOGLEVEL) rebuild \
244244
--python="$(PYTHON)" \

0 commit comments

Comments
 (0)