Skip to content

Commit d5f03db

Browse files
santigimenoMylesBorins
authored andcommitted
test: fix test-cluster-dgram-1 flakiness
Check for the number of messages received in the `exit` event listener instead of the `disconnect` listener. Fixes: #8380 Ref: #8383 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed By: James M Snell <[email protected]>
1 parent 72be320 commit d5f03db

File tree

1 file changed

+7
-8
lines changed

1 file changed

+7
-8
lines changed

test/parallel/test-cluster-dgram-1.js

+7-8
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,14 @@ function master() {
6363
function setupWorker(worker) {
6464
var received = 0;
6565

66-
worker.on('message', function(msg) {
66+
worker.on('message', common.mustCall((msg) => {
6767
received = msg.received;
68-
console.log('worker %d received %d packets', worker.id, received);
69-
});
68+
worker.disconnect();
69+
}));
7070

71-
worker.on('disconnect', function() {
72-
assert(received === PACKETS_PER_WORKER);
73-
console.log('worker %d disconnected', worker.id);
74-
});
71+
worker.on('exit', common.mustCall(() => {
72+
assert.strictEqual(received, PACKETS_PER_WORKER);
73+
}));
7574
}
7675
}
7776

@@ -88,7 +87,7 @@ function worker() {
8887
// Every 10 messages, notify the master.
8988
if (received == PACKETS_PER_WORKER) {
9089
process.send({received: received});
91-
process.disconnect();
90+
socket.close();
9291
}
9392
});
9493

0 commit comments

Comments
 (0)