Skip to content

Commit d641164

Browse files
Trottitaloacasas
authored andcommitted
doc: update pull request template URL layout
Putting the link for the commit guideline at the bottom of the pull request template makes it a bit confusing when opening a pull request as the markdown does not render. Not everyone is familiar with the syntax used there and it is easy to mess it up (for example, by not leaving a blank line above it). It is more natural and useful if the URL is included inline. PR-URL: #12216 Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: Vse Mozhet Byt <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Timothy Gu <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 6feea08 commit d641164

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/PULL_REQUEST_TEMPLATE.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
1313
- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes
1414
- [ ] tests and/or benchmarks are included
1515
- [ ] documentation is changed or added
16-
- [ ] commit message follows [commit guidelines][]
16+
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines)
1717

1818
##### Affected core subsystem(s)
1919
<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->
20-
21-
[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines

0 commit comments

Comments
 (0)