Skip to content

Commit d7afa17

Browse files
TrottMylesBorins
authored andcommitted
test: fix error handling test-http-full-response
The way it is currently written, test-http-full-response will fail if there is a problem with spawning that doesn't include `ab` or `api` in `stderr`, but it will fail with a misleading mismatched-calls `common.mustCall()` error. Alter the error handling so that it rethrows the actual error, providing better information. PR-URL: #14252 Reviewed-By: Yuta Hiroto <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Gibson Fahnestock <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 7a8eddf commit d7afa17

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

test/parallel/test-http-full-response.js

+1-2
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ function runAb(opts, callback) {
2525
common.printSkipMessage(`problem spawning \`ab\`.\n${stderr}`);
2626
process.reallyExit(0);
2727
}
28-
process.exit();
29-
return;
28+
throw err;
3029
}
3130

3231
let m = /Document Length:\s*(\d+) bytes/i.exec(stdout);

0 commit comments

Comments
 (0)