Skip to content

Commit d98ae6a

Browse files
bnoordhuisjasnell
authored andcommitted
build: don't build icu with -fno-rtti
ICU should be compiled with -frtti (and it sets that flag in its gyp file) but it was also inheriting the -fno-rtti flag from common.gypi, breaking the build on some systems. Fixes: #8867 PR-URL: #8886 Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]>
1 parent ece4b2d commit d98ae6a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

tools/icu/icu-generic.gyp

+1
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,7 @@
6767
[ 'os_posix == 1 and OS != "mac" and OS != "ios"', {
6868
'cflags': [ '-Wno-deprecated-declarations' ],
6969
'cflags_cc': [ '-frtti' ],
70+
'cflags_cc!': [ '-fno-rtti' ],
7071
}],
7172
[ 'OS == "mac" or OS == "ios"', {
7273
'xcode_settings': {'GCC_ENABLE_CPP_RTTI': 'YES' },

0 commit comments

Comments
 (0)