Skip to content

Commit db79276

Browse files
addaleaxtargos
authored andcommitted
tracing: remove shutdown-on-signal
This feature cannot be reasonably implemented this way without inherently being susceptible to race conditions that lead to hangs, crashes, etc. What’s more, implementing this for some signals only (and it can only be implemented for some signals at all) may lead to the impression that it is a guaranteed feature, when really consumers of the tracing output *need* to be able to handle abrupt ends meaningfully. Fixes: #14802 Fixes: #22528 PR-URL: #22734 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ali Ijaz Sheikh <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent bc07612 commit db79276

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

src/node.cc

-1
Original file line numberDiff line numberDiff line change
@@ -2052,7 +2052,6 @@ void SetupProcessObject(Environment* env,
20522052

20532053
void SignalExit(int signo) {
20542054
uv_tty_reset_mode();
2055-
v8_platform.StopTracingAgent();
20562055
#ifdef __FreeBSD__
20572056
// FreeBSD has a nasty bug, see RegisterSignalHandler for details
20582057
struct sigaction sa;

0 commit comments

Comments
 (0)