Skip to content

Commit dc0ae8b

Browse files
joaocgreisaddaleax
authored andcommitted
build,win: respect VS version for building addons
When building in machines with multiple versions of Visual Studio installed, node-gyp should respect the vs2015/vs2017 arguments passed to vcbuild.bat instead of relying on its own detection mechanism. PR-URL: #13911 Reviewed-By: Refael Ackermann <[email protected]>
1 parent cd9ef93 commit dc0ae8b

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

vcbuild.bat

+6-3
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,9 @@ if defined build_release (
122122

123123
:: assign path to node_exe
124124
set "node_exe=%config%\node.exe"
125+
set "node_gyp_exe="%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp"
126+
if "%target_env%"=="vs2015" set "node_gyp_exe=%node_gyp_exe% --msvs_version=2015"
127+
if "%target_env%"=="vs2017" set "node_gyp_exe=%node_gyp_exe% --msvs_version=2017"
125128

126129
if "%config%"=="Debug" set configure_flags=%configure_flags% --debug
127130
if defined nosnapshot set configure_flags=%configure_flags% --without-snapshot
@@ -351,7 +354,7 @@ ssh -F %SSHCONFIG% %STAGINGSERVER% "touch nodejs/%DISTTYPEDIR%/v%FULLVERSION%/no
351354

352355
@rem Build test/gc add-on if required.
353356
if "%build_testgc_addon%"=="" goto build-addons
354-
"%config%\node" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild --directory="%~dp0test\gc" --nodedir="%~dp0."
357+
%node_gyp_exe% rebuild --directory="%~dp0test\gc" --nodedir="%~dp0."
355358
if errorlevel 1 goto build-testgc-addon-failed
356359
goto build-addons
357360

@@ -376,7 +379,7 @@ if %errorlevel% neq 0 exit /b %errorlevel%
376379
:: building addons
377380
setlocal EnableDelayedExpansion
378381
for /d %%F in (test\addons\*) do (
379-
"%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild ^
382+
%node_gyp_exe% rebuild ^
380383
--directory="%%F" ^
381384
--nodedir="%cd%"
382385
if !errorlevel! neq 0 exit /b !errorlevel!
@@ -395,7 +398,7 @@ for /d %%F in (test\addons-napi\??_*) do (
395398
)
396399
:: building addons-napi
397400
for /d %%F in (test\addons-napi\*) do (
398-
"%node_exe%" deps\npm\node_modules\node-gyp\bin\node-gyp rebuild ^
401+
%node_gyp_exe% rebuild ^
399402
--directory="%%F" ^
400403
--nodedir="%cd%"
401404
)

0 commit comments

Comments
 (0)