Skip to content

Commit dccd1d2

Browse files
mscdexjasnell
authored andcommitted
test: improve dns internet test case
0.0.0.0 is more common than other special ipv4 addresses, so it is possible that we may not get ENOTFOUND for such addresses. Instead, this commit uses a less common address that is reserved for documentation (RFC) use only. PR-URL: #13261 Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 315c3aa commit dccd1d2

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

test/internet/test-dns.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -492,11 +492,12 @@ TEST(function test_lookupservice_invalid(done) {
492492

493493

494494
TEST(function test_reverse_failure(done) {
495-
const req = dns.reverse('0.0.0.0', function(err) {
495+
// 203.0.113.0/24 are addresses reserved for (RFC) documentation use only
496+
const req = dns.reverse('203.0.113.0', function(err) {
496497
assert(err instanceof Error);
497498
assert.strictEqual(err.code, 'ENOTFOUND'); // Silly error code...
498-
assert.strictEqual(err.hostname, '0.0.0.0');
499-
assert.ok(/0\.0\.0\.0/.test(err.message));
499+
assert.strictEqual(err.hostname, '203.0.113.0');
500+
assert.ok(/203\.0\.113\.0/.test(err.message));
500501

501502
done();
502503
});

0 commit comments

Comments
 (0)