fixup! fixup! test,debugger: migrate node-inspect tests to core

Trott · Trott · commit dce5476d1b80 · 2021-04-09T06:49:24.000-07:00
diff --git a/test/inspector-cli/test-inspector-cli-backtrace.js b/test/inspector-cli/test-inspector-cli-backtrace.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-break.js b/test/inspector-cli/test-inspector-cli-break.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-clear-breakpoints.js b/test/inspector-cli/test-inspector-cli-clear-breakpoints.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-exceptions.js b/test/inspector-cli/test-inspector-cli-exceptions.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-exec-scope.js b/test/inspector-cli/test-inspector-cli-exec-scope.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/backtrace.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-exec.js b/test/inspector-cli/test-inspector-cli-exec.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/alive.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-heap-profiler.js b/test/inspector-cli/test-inspector-cli-heap-profiler.js
@@ -19,6 +19,8 @@ const filename = 'node.heapsnapshot';
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-help.js b/test/inspector-cli/test-inspector-cli-help.js
@@ -12,6 +12,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-low-level.js b/test/inspector-cli/test-inspector-cli-low-level.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const scriptPattern = /^\* (\d+): \S+inspector-cli(?:\/|\\)three-lines\.js/m;
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-preserve-breaks.js b/test/inspector-cli/test-inspector-cli-preserve-breaks.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-profile.js b/test/inspector-cli/test-inspector-cli-profile.js
@@ -17,6 +17,8 @@ function delay(ms) {
   const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-run-after-quit-restart.js b/test/inspector-cli/test-inspector-cli-run-after-quit-restart.js
@@ -16,6 +16,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-sb-before-load.js b/test/inspector-cli/test-inspector-cli-sb-before-load.js
@@ -20,6 +20,8 @@ const path = require('path');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-scripts.js b/test/inspector-cli/test-inspector-cli-scripts.js
@@ -14,6 +14,8 @@ const assert = require('assert');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-use-strict.js b/test/inspector-cli/test-inspector-cli-use-strict.js
@@ -14,6 +14,8 @@ const assert = require('assert');
   const cli = startCLI([script]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }
diff --git a/test/inspector-cli/test-inspector-cli-watchers.js b/test/inspector-cli/test-inspector-cli-watchers.js
@@ -13,6 +13,8 @@ const assert = require('assert');
   const cli = startCLI([fixtures.path('inspector-cli/break.js')]);
 
   function onFatal(error) {
+    // Print the error first because `cli.quit()` might throw something else.
+    console.error(`Error received: ${error}`);
     cli.quit();
     throw error;
   }

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,8 @@ const path = require('path');`
`16`	`16`	`const cli = startCLI([script]);`
`17`	`17`
`18`	`18`	`function onFatal(error) {`
	`19`	+ // Print the error first because `cli.quit()` might throw something else.
	`20`	+ console.error(`Error received: ${error}`);
`19`	`21`	`cli.quit();`
`20`	`22`	`throw error;`
`21`	`23`	`}`
Original file line number	Diff line number	Diff line change
`@@ -13,6 +13,8 @@ const assert = require('assert');`
`13`	`13`	`const cli = startCLI([fixtures.path('inspector-cli/backtrace.js')]);`
`14`	`14`
`15`	`15`	`function onFatal(error) {`
	`16`	+ // Print the error first because `cli.quit()` might throw something else.
	`17`	+ console.error(`Error received: ${error}`);
`16`	`18`	`cli.quit();`
`17`	`19`	`throw error;`
`18`	`20`	`}`
Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,8 @@ const filename = 'node.heapsnapshot';`
`19`	`19`	`const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);`
`20`	`20`
`21`	`21`	`function onFatal(error) {`
	`22`	+ // Print the error first because `cli.quit()` might throw something else.
	`23`	+ console.error(`Error received: ${error}`);
`22`	`24`	`cli.quit();`
`23`	`25`	`throw error;`
`24`	`26`	`}`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@ const assert = require('assert');`
`12`	`12`	`const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);`
`13`	`13`
`14`	`14`	`function onFatal(error) {`
	`15`	+ // Print the error first because `cli.quit()` might throw something else.
	`16`	+ console.error(`Error received: ${error}`);
`15`	`17`	`cli.quit();`
`16`	`18`	`throw error;`
`17`	`19`	`}`
Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,8 @@ function delay(ms) {`
`17`	`17`	`const cli = startCLI([fixtures.path('inspector-cli/empty.js')]);`
`18`	`18`
`19`	`19`	`function onFatal(error) {`
	`20`	+ // Print the error first because `cli.quit()` might throw something else.
	`21`	+ console.error(`Error received: ${error}`);
`20`	`22`	`cli.quit();`
`21`	`23`	`throw error;`
`22`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -20,6 +20,8 @@ const path = require('path');`
`20`	`20`	`const cli = startCLI([script]);`
`21`	`21`
`22`	`22`	`function onFatal(error) {`
	`23`	+ // Print the error first because `cli.quit()` might throw something else.
	`24`	+ console.error(`Error received: ${error}`);
`23`	`25`	`cli.quit();`
`24`	`26`	`throw error;`
`25`	`27`	`}`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,8 @@ const assert = require('assert');`
`14`	`14`	`const cli = startCLI([script]);`
`15`	`15`
`16`	`16`	`function onFatal(error) {`
	`17`	+ // Print the error first because `cli.quit()` might throw something else.
	`18`	+ console.error(`Error received: ${error}`);
`17`	`19`	`cli.quit();`
`18`	`20`	`throw error;`
`19`	`21`	`}`