Skip to content

Commit dd5d944

Browse files
tniessenBridgeAR
authored andcommitted
crypto: fix OpenSSL return code handling
PR-URL: #29489 Reviewed-By: David Carlier <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: James M Snell <[email protected]>
1 parent 54f327b commit dd5d944

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/node_crypto.cc

+3-2
Original file line numberDiff line numberDiff line change
@@ -5215,15 +5215,16 @@ bool PublicKeyCipher::Cipher(Environment* env,
52155215
return false;
52165216

52175217
if (digest != nullptr) {
5218-
if (!EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest))
5218+
if (EVP_PKEY_CTX_set_rsa_oaep_md(ctx.get(), digest) <= 0)
52195219
return false;
52205220
}
52215221

52225222
if (oaep_label_len != 0) {
52235223
// OpenSSL takes ownership of the label, so we need to create a copy.
52245224
void* label = OPENSSL_memdup(oaep_label, oaep_label_len);
52255225
CHECK_NOT_NULL(label);
5226-
if (!EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label, oaep_label_len)) {
5226+
if (0 >= EVP_PKEY_CTX_set0_rsa_oaep_label(ctx.get(), label,
5227+
oaep_label_len)) {
52275228
OPENSSL_free(label);
52285229
return false;
52295230
}

0 commit comments

Comments
 (0)