Skip to content

Commit de744ba

Browse files
bnoordhuisaddaleax
authored andcommitted
n-api: use Maybe version of Object::SetPrototype()
Fixes the following deprecation warning: ../src/node_api.cc:2020:30: warning: 'bool v8::Object::SetPrototype(v8::Local<v8::Value>)' is deprecated: Use maybe version [-Wdeprecated-declarations] wrapper->SetPrototype(proto); ../src/node_api.cc:2021:28: warning: 'bool v8::Object::SetPrototype(v8::Local<v8::Value>)' is deprecated: Use maybe version [-Wdeprecated-declarations] obj->SetPrototype(wrapper); PR-URL: #14053 Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Franziska Hinkelmann <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
1 parent 7b369d1 commit de744ba

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/node_api.cc

+2-2
Original file line numberDiff line numberDiff line change
@@ -2017,8 +2017,8 @@ napi_status napi_wrap(napi_env env,
20172017

20182018
// Insert the wrapper into the object's prototype chain.
20192019
v8::Local<v8::Value> proto = obj->GetPrototype();
2020-
wrapper->SetPrototype(proto);
2021-
obj->SetPrototype(wrapper);
2020+
CHECK(wrapper->SetPrototype(context, proto).FromJust());
2021+
CHECK(obj->SetPrototype(context, wrapper).FromJust());
20222022

20232023
if (result != nullptr) {
20242024
// The returned reference should be deleted via napi_delete_reference()

0 commit comments

Comments
 (0)