Skip to content

Commit dedbd11

Browse files
Robert Nagytargos
Robert Nagy
authored andcommitted
http: fix event listener leak
Fixes: #29239 PR-URL: #29245 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Matteo Collina <[email protected]>
1 parent 3cc8fca commit dedbd11

File tree

2 files changed

+12
-1
lines changed

2 files changed

+12
-1
lines changed

lib/_http_client.js

+2
Original file line numberDiff line numberDiff line change
@@ -502,6 +502,7 @@ function socketOnData(d) {
502502
!statusIsInformational(parser.incoming.statusCode)) {
503503
socket.removeListener('data', socketOnData);
504504
socket.removeListener('end', socketOnEnd);
505+
socket.removeListener('drain', ondrain);
505506
freeParser(parser, req, socket);
506507
}
507508
}
@@ -609,6 +610,7 @@ function responseKeepAlive(res, req) {
609610
}
610611
socket.removeListener('close', socketCloseListener);
611612
socket.removeListener('error', socketErrorListener);
613+
socket.removeListener('drain', ondrain);
612614
socket.once('error', freeSocketErrorListener);
613615
// There are cases where _handle === null. Avoid those. Passing null to
614616
// nextTick() will call getDefaultTriggerAsyncId() to retrieve the id.

test/parallel/test-http-agent-keepalive.js

+10-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ function get(path, callback) {
5252
port: server.address().port,
5353
agent: agent,
5454
path: path
55-
}, callback);
55+
}, callback).on('socket', common.mustCall(checkListeners));
5656
}
5757

5858
function checkDataAndSockets(body) {
@@ -134,3 +134,12 @@ server.listen(0, common.mustCall(() => {
134134
}));
135135
}));
136136
}));
137+
138+
// Check for listener leaks when reusing sockets.
139+
function checkListeners(socket) {
140+
assert.strictEqual(socket.listenerCount('data'), 1);
141+
assert.strictEqual(socket.listenerCount('drain'), 1);
142+
assert.strictEqual(socket.listenerCount('error'), 1);
143+
// Sockets have onReadableStreamEnd.
144+
assert.strictEqual(socket.listenerCount('end'), 2);
145+
}

0 commit comments

Comments
 (0)